You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/11/22 01:14:12 UTC

[GitHub] [samza] atoomula commented on a change in pull request #1222: SAMZA-2396: Support dynamic addition of jars in ReflectionUdfResolver.

atoomula commented on a change in pull request #1222: SAMZA-2396: Support dynamic addition of jars in ReflectionUdfResolver.
URL: https://github.com/apache/samza/pull/1222#discussion_r349394635
 
 

 ##########
 File path: samza-sql/src/main/java/org/apache/samza/sql/udf/ReflectionBasedUdfResolver.java
 ##########
 @@ -49,20 +54,26 @@
   private static final Logger LOG = LoggerFactory.getLogger(ReflectionBasedUdfResolver.class);
 
   private static final String CONFIG_PACKAGE_PREFIX = "samza.sql.udf.resolver.package.prefix";
 
 Review comment:
   remove this ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services