You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/25 09:46:07 UTC

[GitHub] [orc] pgaref commented on a change in pull request #669: ORC-773: BinaryColumnWriter does not update Bloom filter

pgaref commented on a change in pull request #669:
URL: https://github.com/apache/orc/pull/669#discussion_r601273303



##########
File path: c++/src/ColumnWriter.cc
##########
@@ -1683,6 +1683,9 @@ namespace orc {
       if (!notNull || notNull[i]) {
         directDataStream->write(data[i], unsignedLength);
 
+        if (enableBloomFilter) {

Review comment:
       +1 This looks to be on par with the ColumnWriters above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org