You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/26 14:55:00 UTC

[GitHub] [ratis] SzyWilliam commented on pull request #712: RATIS-1671. Add manual trigger snapshot

SzyWilliam commented on PR #712:
URL: https://github.com/apache/ratis/pull/712#issuecomment-1228597622

   @szetszwo Thanks for the reviews! I've made corresponding changes. However, if we have a function return type `Void` and return value `null`, `Optional.map` will return Optional.Empty, and `isPresent` on Empty will return false. Therefore, I have the previous code `return true` unmodified so that `sent` is properly assigned. Please take a look at it~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org