You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/03/25 10:14:12 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4476: HDDS-8275. ManagedWriteBatch is not closed properly in SCMHADBTransactionBuffer
adoroszlai opened a new pull request, #4476:
URL: https://github.com/apache/ozone/pull/4476
## What changes were proposed in this pull request?
* Close `DBTransactionBuffer` in `SCMHAManagerImpl`
* Close `SCMHAManager` even if SCM is not started, since it needs to close the eagerly created `DBTransactionBuffer`
* Similarly, `ReplicationManager` is eagerly started, so it needs to be stopped even if SCM is not started
* Close previous `BatchOperation` in `SCMHADBTransactionBufferImpl`, as new one is created when snapshot is installed
* Close `ManagedWriteBatch` in `SCMHADBTransactionBufferStub` (used for tests and Recon) even if `DBStore` is not created
https://issues.apache.org/jira/browse/HDDS-8275
## How was this patch tested?
`TestSCMInstallSnapshot` and `TestSCMInstallSnapshotWithHA` do not log not properly closed `ManagedWriteBatch`.
```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.839 s - in org.apache.hadoop.ozone.scm.TestSCMInstallSnapshotWithHA
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.012 s - in org.apache.hadoop.hdds.scm.TestSCMInstallSnapshot
...
$ grep -c 'not closed' hadoop-ozone/integration-test/target/surefire-reports/*output.txt
hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.hdds.scm.TestSCMInstallSnapshot-output.txt:0
hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.ozone.scm.TestSCMInstallSnapshotWithHA-output.txt:0
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4517815043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4476: HDDS-8275. ManagedWriteBatch is not closed properly in SCMHADBTransactionBuffer
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4476:
URL: https://github.com/apache/ozone/pull/4476#issuecomment-1485717438
Thanks @duongkame, @sodonnel for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4476: HDDS-8275. ManagedWriteBatch is not closed properly in SCMHADBTransactionBuffer
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4476:
URL: https://github.com/apache/ozone/pull/4476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org