[jira] Commented: (SOLR-2292) Lock down NamedList API, remove inefficent and esoteric methods

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985503#action_12985503 ] 

Mark Miller commented on SOLR-2292:
-----------------------------------

No patches yet - any chance of this for a nearing 3.1?

> Lock down NamedList API, remove inefficent and esoteric methods
> ---------------------------------------------------------------
>
>                 Key: SOLR-2292
>                 URL: https://issues.apache.org/jira/browse/SOLR-2292
>             Project: Solr
>          Issue Type: Task
>            Reporter: Hoss Man
>             Fix For: 3.1
>
>
> Over in SOLR-2288, rmuir made some good points about locking down the NamedList API to protect people...
> {quote}
> I looked at your patch, and personally I think NamedList should really be type-safe.
> If users want to use it in a type-unsafe way, thats fine, but *the container itself shouldn't be List<Object>*.
> {quote}
> ...
> {quote}
> Separately, i just want to say the following about NamedList:
> All uses of this API should really be reviewed. I'm quite aware that it warns you about the fact that its slow for certain operations,
> but in my opinion these *slow operations such as get(String, int) should be deprecated and removed*.
> Any users that are using NamedList in this way, especially in loops, are very likely using the wrong datastructure.
> {quote}
> (emphasis added by me)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org