You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/03/11 17:51:02 UTC
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18311
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
IMPALA-11177: Remove DCHECK in useAsyncIoForStream
TestScannersFuzzing::test_fuzz_alltypes tests how impala handles
corruption in data files. IMPALA-6636 adds support for ORC async IO
where it put DCHECK within method useAsyncIoForStream to verify correct
orc::StreamKind. If this part of the ORC test file is corrupted, impalad
will crash in this DCHECK. We should remove this DCHECK and let ORC lib
deals with the corrupted orc::StreamKind itself.
Testing:
- Run and pass TestScannersFuzzing::test_fuzz_alltypes
Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/18311/1
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18311 )
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10282/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 18:10:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18311 )
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 23:22:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18311 )
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7929/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 23:23:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18311 )
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Mar 2022 04:12:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18311 )
Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream
......................................................................
IMPALA-11177: Remove DCHECK in useAsyncIoForStream
TestScannersFuzzing::test_fuzz_alltypes tests how impala handles
corruption in data files. IMPALA-6636 adds support for ORC async IO
where it put DCHECK within method useAsyncIoForStream to verify correct
orc::StreamKind. If this part of the ORC test file is corrupted, impalad
will crash in this DCHECK. We should remove this DCHECK and let ORC lib
deals with the corrupted orc::StreamKind itself.
Testing:
- Run and pass TestScannersFuzzing::test_fuzz_alltypes
Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Reviewed-on: http://gerrit.cloudera.org:8080/18311
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I70b21badf39869091feff202e7a08a8460abf9db
Gerrit-Change-Number: 18311
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>