You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:41:07 UTC
[GitHub] [dolphinscheduler-website] QuakeWang opened a new pull request #456: [Translation] Translating Task_SPI.md
QuakeWang opened a new pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456
Although summer2021 is over, I still want to contribute to the community. Since I have limited energy at the moment, I will mainly contribute to the documentation.
Translating [Task_SPI](https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/task_spi.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] CalvinKirs commented on a change in pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#discussion_r734320036
##########
File path: docs/en-us/dev/user_doc/task_spi.md
##########
@@ -0,0 +1,34 @@
+## DolphinScheduler Task SPI main design
+
+#### How to use development environment?
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/task (The version number will follow the change of the main version number)
+
Review comment:
No need to execute ‘-Prelease ’
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#issuecomment-947371715
@QuakeWang Thanks for you contribution, SOC is just a way to know how OSS work and how to contribute it. If you like OSS after your SOC, you could continue to contribute to OSS.
We will be happy, if you thinks DolphinScheduler is great and want to contribute it. ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#discussion_r732457532
##########
File path: docs/zh-cn/dev/user_doc/task_spi.md
##########
@@ -1,4 +1,4 @@
-## DolphinScheduler Registry SPI 主要设计
+## DolphinScheduler Task SPI 主要设计
Review comment:
Good catch !
##########
File path: site_config/docsdev.js
##########
@@ -254,6 +254,10 @@ export default {
title: 'Registry-SPI',
link: '/en-us/docs/dev/user_doc/registry_spi.html',
},
+ {
+ title: 'Task-SPI',
+ link: '/en-us/docs/dev/user_doc/task_spi.html',
+ },
Review comment:
We have to discuss where should we put our SPI documentation. I thinks we should create subpage for https://dolphinscheduler.apache.org/zh-cn/development/backend-development.html to hold this content? Do you have other idea? @lenboo @CalvinKirs @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] caishunfeng commented on a change in pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on a change in pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#discussion_r732606963
##########
File path: site_config/docsdev.js
##########
@@ -254,6 +254,10 @@ export default {
title: 'Registry-SPI',
link: '/en-us/docs/dev/user_doc/registry_spi.html',
},
+ {
+ title: 'Task-SPI',
+ link: '/en-us/docs/dev/user_doc/task_spi.html',
+ },
Review comment:
Yes, SPI subpage is a good idea, and it will contains task、registry or any other spi else. And I think it can be a part of architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] CalvinKirs merged pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#issuecomment-949352485
Hi @QuakeWang, since we merge PR https://github.com/apache/dolphinscheduler-website/pull/459, SPI documentations are move to `developement` tab. Could you please move your change to https://github.com/apache/dolphinscheduler-website/tree/master/development/en-us/backend/spi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on pull request #456: [Translation] Translating Task_SPI.md
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on pull request #456:
URL: https://github.com/apache/dolphinscheduler-website/pull/456#issuecomment-950154801
> Hi @QuakeWang, since we merge PR #459, SPI documentations are move to `developement` tab. Could you please move your change to https://github.com/apache/dolphinscheduler-website/tree/master/development/en-us/backend/spi?
done ：）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org