[GitHub] [spark] sarutak commented on a change in pull request #31718: [SPARK-34225][CORE] Don't encode further when a URI form string is passed to addFile or addJar

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #31718:
URL: https://github.com/apache/spark/pull/31718#discussion_r612884387



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1584,7 +1584,11 @@ class SparkContext(config: SparkConf) extends Logging {
       path: String, recursive: Boolean, addedOnSubmit: Boolean, isArchive: Boolean = false
     ): Unit = {
     val uri = if (!isArchive) {
-      new Path(path).toUri
+      if (Utils.isAbsoluteURI(path) && path.contains("%")) {
+        new URI(path)
+      } else {
+        new Path(path).toUri
+      }
     } else {
       Utils.resolveURI(path)

Review comment:
       Yeah, the behavior of `Path` seems to be a little bit confusable and there may be lots of places where `Path` does not behave  as we expect.
   O.K, I'll looking into it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org