You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "f2par0 (via GitHub)" <gi...@apache.org> on 2024/07/29 12:41:07 UTC
[PR] Add camel-cometd integration test [camel-karaf]
f2par0 opened a new pull request, #469:
URL: https://github.com/apache/camel-karaf/pull/469
Fixes #468
- feature need dependency fix
- integration test doesn't work with the current framework because the bundle camel-integration-test which starts the route does not fails to start the route with cometd because it dynamically loads transport classes which are in the cometd dependencies.
To overcome this issues, the comted integration test bundle is packaged as a fragment of camel-integration-test and alters it's `Import-Package` section to add the necessary dependencies to the route.
Since it's a fragment, the Supplier registration doesn't work, so I added a mechanism where the RouteLoader tries to read a specific system property (`supplier-class`) to load the supplier class. In case it's set, it loads it an populate the route. This allows, when `update` is called on the host bundle (`camel-integration-test`) to discover the cometd route supplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add camel-cometd integration test [camel-karaf]
Posted by "f2par0 (via GitHub)" <gi...@apache.org>.
f2par0 commented on PR #469:
URL: https://github.com/apache/camel-karaf/pull/469#issuecomment-2257902830
New version uses a blueprint file to avoid having to modify the framework.
I tried to set the manifest in the blueprint but it doesn't work so I left the deployment of `camel-cometd-test` as a fragment to be able to import the right packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add camel-cometd integration test [camel-karaf]
Posted by "f2par0 (via GitHub)" <gi...@apache.org>.
f2par0 commented on PR #469:
URL: https://github.com/apache/camel-karaf/pull/469#issuecomment-2257680506
> It brings a lot of additional complexity to the framework just for one test that seems to be a corner case, this test should be written using blueprint instead of pure Java.
Ok, I will try to combine blueprint + fragment to avoid to have the new property. A mere blueprint test does work with the current framework for the same reason : the route is started by camel-integration-test which doesn't have the right imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add camel-cometd integration test [camel-karaf]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #469:
URL: https://github.com/apache/camel-karaf/pull/469#issuecomment-2258191835
please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add camel-cometd integration test [camel-karaf]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #469:
URL: https://github.com/apache/camel-karaf/pull/469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org