You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/05 16:30:12 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
gemmellr opened a new pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785
Unwinds the effects of the RFC 2712 'Kerberos SSL ciphers' support added in ARTEMIS-1264. The functionality was recommended against use even then, and was removed entirely from JDK11. It has been disabled by default in JDK8 for a while. OpenSSL removed its equivalent support in 2015. It is no longer being tested, with the tests already removed (a3de3d4c75ba1482706e8c42a5c9b0f9811901eb) since no modern JVMs can do it out of the box.
The code has changed and moved around a lot since as the surrounding areas were updated, other functionality added etc, so this was a case of making the related unwinds rather than reverting what was added as such. The docs included a note of the support, including mention it is insecure, though the specific steps needed to configure and use it were seemingly never added.
Once #3696 lands this functionality becomes 100% defunct, but its largely already unusable and shouldn't really be used anyway so I don't think this PR needs to wait for that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937629823
It was mostly opinion on the timing I was looking for, so if you were inclined just to merge it then I will do so now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937847908
I think it's good timing already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937130683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-934569169
@gtully can you take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937130683
@gemmellr I can't say no to removing code :). LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937629823
It was mostly opinion on the timing I was looking for, so if you were inclined just to merge it then I will do so now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-937131891
I was tempted to hit Rebase and merge already.. I will let you do it in case you want more reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3785: ARTEMIS-3038: unwind effect of defunct changes from ARTEMIS-1264
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3785:
URL: https://github.com/apache/activemq-artemis/pull/3785#issuecomment-935763197
Great. I'll leave it open for further opinions on when it should go in. @jbertram @clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org