You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4net-dev@logging.apache.org by Newtopian <gi...@git.apache.org> on 2015/03/09 22:16:12 UTC

[GitHub] log4net pull request: Trimmed list seperator when sending mails

GitHub user Newtopian opened a pull request:

    https://github.com/apache/log4net/pull/13

    Trimmed list seperator when sending mails

    When sending a mail if the list contains leading or trailing seperator the mail send can fail.
    
    This way it is possible to set a constant recipient like so :
    
        <to type="log4net.Util.PatternString" value="somestaticrecipient@somedomain.org,%property{FailureMailRecipient}" />
    
    instead of 
    <to type="log4net.Util.PatternString" value="somestaticrecipient@somedomain.org%property{FailureMailRecipient}" />
    
    which forces us to handle code side the presence or not of the leading comma (or semicolon).
    
    the proposed way makes cleaner separation of concerns allowing us to configure code side without having to check pre-conditions in the config of Log4Net

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Newtopian/log4net trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/log4net/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 1f7349064727263bafafae8d3f19f301c0e1e942
Author: Éric Daigneault <sa...@gmail.com>
Date:   2015-03-09T21:10:29Z

    Trimmed list seperator when sending mails

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request: Trimmed list seperator when sending mails

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/log4net/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request: Trimmed list seperator when sending mails

Posted by bodewig <gi...@git.apache.org>.

Github user bodewig commented on the pull request:

    https://github.com/apache/log4net/pull/13#issuecomment-78293988
  
    I took a freedom to modify the patch a little


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request: Trimmed list seperator when sending mails

Posted by bodewig <gi...@git.apache.org>.

Github user bodewig commented on the pull request:

    https://github.com/apache/log4net/pull/13#issuecomment-78291627
  
    tracked by LOG4NET-457


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---