[GitHub] [druid] jon-wei commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib

[GitBox <gi...@apache.org>]

jon-wei commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib
URL: https://github.com/apache/druid/pull/8992#issuecomment-601947906
 
 
   > writing integration tests for this is kind of challenging because of dependency on an external system and would require significant work on test client to be able to interface with okta to follow redirect, complete auth protocol with okta and come back to druid process with necessary tokens .
   
   Hm, for handling the external system dependency, I was thinking of a "bring your own okta dev server" test where it's the user's responsibility to set one up beforehand and point to it in the integration test config, the test itself could also be optional and not run in Travis.
   
   I think an integration test would be worth adding still.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org