[GitHub] [incubator-pegasus] acelyc111 commented on a change in pull request #587: fix(pegasus-server): Load options from file when open an exist DB

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #587:
URL: https://github.com/apache/incubator-pegasus/pull/587#discussion_r478799945



##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -1375,7 +1414,12 @@ ::dsn::error_code pegasus_server_impl::start(int argc, char **argv)
         _meta_store->set_data_version(PEGASUS_DATA_VERSION_MAX);
         _meta_store->set_last_flushed_decree(0);
         _meta_store->set_last_manual_compact_finish_time(0);
+        _meta_store->set_usage_scenario(ROCKSDB_ENV_USAGE_SCENARIO_NORMAL);

Review comment:
       We can specify envs when create new table, so actual usage scenario may be included in envs which is passed from meta server, see https://github.com/apache/incubator-pegasus/blob/dea9756663847acb326539f61b80c6c48f92456e/src/server/pegasus_server_impl.cpp#L1256
   
   You can read it from envs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org