You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2019/08/13 10:25:23 UTC

Should we remove modifiers when default (no modifier) is the same?

Hi,

I was looking at the work done by Pradhan Yash Sharma for OFBIZ-10477 "Parent ticket for reducing scope of variables and methods"

This work is related to https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html

I only applied the patch from OFBIZ-10478 "Reducing scope of variables in org.apache.ofbiz.base package"

Some changes are welcome, to improve security, like replacing public or protected by private when possible

I think removing public modifiers is also a good thing

What do you think?

Jacques

Re: Should we remove modifiers when default (no modifier) is the same?

Posted by Mathieu Lirzin <ma...@nereide.fr>.
Hello Jacques,

Jacques Le Roux <ja...@les7arts.com> writes:

> I was looking at the work done by Pradhan Yash Sharma for OFBIZ-10477 "Parent ticket for reducing scope of variables and methods"
>
> This work is related to https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
>
> I only applied the patch from OFBIZ-10478 "Reducing scope of variables in org.apache.ofbiz.base package"
>
> Some changes are welcome, to improve security, like replacing public or protected by private when possible
>
> I think removing public modifiers is also a good thing
>
> What do you think?

I like the idea.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Should we not remove public modifiers?

Posted by Jacques Le Roux <ja...@les7arts.com>.
Sorry my title was confusing

Le 13/08/2019 à 12:25, Jacques Le Roux a écrit :
> Hi,
>
> I was looking at the work done by Pradhan Yash Sharma for OFBIZ-10477 "Parent ticket for reducing scope of variables and methods"
>
> This work is related to https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
>
> I only applied the patch from OFBIZ-10478 "Reducing scope of variables in org.apache.ofbiz.base package"
>
> Some changes are welcome, to improve security, like replacing public or protected by private when possible
>
> I think removing public modifiers is also a good thing
>
> What do you think?
>
> Jacques
>