[GitHub] [helix] jiajunwang commented on a change in pull request #413: Add cluster level default instance config.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #413: Add cluster level default instance config.
URL: https://github.com/apache/helix/pull/413#discussion_r314870372
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java
 ##########
 @@ -88,11 +88,15 @@ private void refresh(ClusterConfig clusterConfig, InstanceConfig instanceConfig,
       Collection<AssignableReplica> existingAssignment) {
     reset();
 
-    _currentCapacity.putAll(instanceConfig.getInstanceCapacityMap());
+    Map<String, Integer> instanceCapaity = instanceConfig.getInstanceCapacityMap();
 
 Review comment:
   getInstanceCapacityMap won't return null. This is guaranteed and the unit test covers it.
   
   You are right. That one of the reasons why I tried to decouple the model classes as far as I can. In this case, if one instance is not changed, we can just keep it. That can be done in the Cluster Model Provder.
   It is in my plan, but will be future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org