You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/07/28 03:45:07 UTC
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42115: [SPARK-44524][BUILD] Balancing pyspark-pandas-connect and pyspark-pandas-slow-connect GA testing time
zhengruifeng commented on code in PR #42115:
URL: https://github.com/apache/spark/pull/42115#discussion_r1277059876
##########
dev/sparktestsupport/modules.py:
##########
@@ -984,6 +967,23 @@ def __hash__(self):
"pyspark.pandas.tests.connect.computation.test_parity_melt",
"pyspark.pandas.tests.connect.computation.test_parity_missing_data",
"pyspark.pandas.tests.connect.computation.test_parity_pivot",
+ ],
+ excluded_python_implementations=[
+ "PyPy" # Skip these tests under PyPy since they require numpy, pandas, and pyarrow and
+ # they aren't available there
+ ],
+)
+
+
+# This module should contain the same test list with 'pyspark_pandas_slow' for maintenance.
Review Comment:
```suggestion
```
This comment is no longer the truth
##########
dev/sparktestsupport/modules.py:
##########
@@ -984,6 +967,23 @@ def __hash__(self):
"pyspark.pandas.tests.connect.computation.test_parity_melt",
"pyspark.pandas.tests.connect.computation.test_parity_missing_data",
"pyspark.pandas.tests.connect.computation.test_parity_pivot",
+ ],
+ excluded_python_implementations=[
+ "PyPy" # Skip these tests under PyPy since they require numpy, pandas, and pyarrow and
+ # they aren't available there
+ ],
+)
+
+
+# This module should contain the same test list with 'pyspark_pandas_slow' for maintenance.
+pyspark_pandas_slow_connect = Module(
+ name="pyspark-pandas-slow-connect",
+ dependencies=[pyspark_connect, pyspark_pandas_slow],
Review Comment:
```suggestion
dependencies=[pyspark_connect, pyspark_pandas, pyspark_pandas_slow],
```
`pyspark_pandas_connect` should have the same dependencies now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org