You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "kumaab (via GitHub)" <gi...@apache.org> on 2025/06/30 00:46:01 UTC

[PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

kumaab opened a new pull request, #1:
URL: https://github.com/apache/ranger-tools/pull/1

   ## What changes were proposed in this pull request?
   
   Cherry-pick changes from `https://github.com/adoroszlai/ranger-docker-base`
   
   ## How was this patch tested?
   Tested in local setup with:
   ```
   chmod +x build.sh && ./build.sh
   ```
   Pending CI runs:
   - Testing with different Java versions.
   - Testing for different container registries.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab merged PR #1:
URL: https://github.com/apache/ranger-tools/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#issuecomment-3032888550

   To enable publishing to Docker Hub, create an INFRA ticket to add secrets `DOCKERHUB_USER` and `DOCKERHUB_TOKEN` to this GitHub repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#issuecomment-3032868951

   @adoroszlai Thanks for your code reviews. We have a repo `apache/ranger-base` in place in DockerHub now, do you think we can try to run `build-and-tag` workflow to test the push to DockerHub? thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#issuecomment-3025872936

   @adoroszlai Could you please review updated changes, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#issuecomment-3020036702

   Thanks @kumaab for porting the changes to this repo.  If there will be other tools here:
   - Docker files should be in a subdir
   - build/publish workflows should be [limited to files](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore) in the subdir and the workflows themselves


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#discussion_r2179402861


##########
.github/workflows/push.yaml:
##########
@@ -0,0 +1,40 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: push
+
+# This workflow builds (if necessary) and tags the Docker image,
+# possibly for multiple Java versions.
+
+on:
+  push:
+    paths:
+      - 'docker/**'
+      - '.github/workflows/push.yaml'

Review Comment:
   ```suggestion
         - '.github/workflows/build.yaml'
         - '.github/workflows/build-and-tag.yaml'
         - '.github/workflows/push.yaml'
   ```



##########
docker/README.md:
##########
@@ -0,0 +1,24 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+# Apache Ranger Tools
+
+[ranger-tools/docker](https://github.com/apache/ranger-tools/docker) contains utilities for ranger docker base image development, base images are the underlying images used to run and test Apache Ranger in Docker containers.

Review Comment:
   This link is not valid.
   
   ```suggestion
   This directory contains utilities for ranger docker base image development, base images are the underlying images used to run and test Apache Ranger in Docker containers.
   ```



##########
.github/workflows/pr.yaml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PR
+
+# This workflow builds the image for pull requests.
+
+on:
+  pull_request:
+    types: [opened, ready_for_review, synchronize]
+    paths:
+      - 'docker/**'
+      - '.github/workflows/pr.yaml'

Review Comment:
   Also need to trigger if `build.yaml` is changed.
   
   ```suggestion
         - '.github/workflows/build.yaml'
         - '.github/workflows/pr.yaml'
   ```



##########
docker/README.md:
##########
@@ -0,0 +1,24 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+# Apache Ranger Tools

Review Comment:
   ```suggestion
   # Apache Ranger Base Image
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-5158: Enable building ranger base images with CI in apache/ranger-tools [ranger-tools]

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #1:
URL: https://github.com/apache/ranger-tools/pull/1#issuecomment-3021905632

   > Thanks @kumaab for porting the changes to this repo. If there will be other tools here:
   > 
   > * Docker files should be in a subdir
   > * build/publish workflows should be [limited to files](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore) in the subdir and the workflows themselves
   
   Thanks @adoroszlai for taking a look, I will re-factor and get back soon for review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org