You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/16 16:06:13 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3819: chore: remove deprecated code
squakez opened a new pull request, #3819:
URL: https://github.com/apache/camel-k/pull/3819
Cleaning PR to remove the old deprecated stuff in the code. The only doubt I have is if we want to keep it in the next minor (1.11.0) or we should strictly follow semantic version and bump the major.
Closes #3787
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3819: chore: remove deprecated code
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3819:
URL: https://github.com/apache/camel-k/pull/3819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3819: chore: remove deprecated code
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3819:
URL: https://github.com/apache/camel-k/pull/3819#discussion_r1024694447
##########
pkg/apis/camel/v1alpha1/kamelet_types_support.go:
##########
@@ -192,13 +192,10 @@ func ValidKameletProperties(kamelet *Kamelet) bool {
return true
}
-func ValidKameletTemplate(kamelet *Kamelet) bool {
+func ValidKamelet(kamelet *Kamelet) bool {
Review Comment:
Looks like this function doesn't do anything anymore. Probably better to remove it. Or add some meaningful check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3819: chore: remove deprecated code
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3819:
URL: https://github.com/apache/camel-k/pull/3819#discussion_r1024881651
##########
pkg/apis/camel/v1alpha1/kamelet_types_support.go:
##########
@@ -192,13 +192,10 @@ func ValidKameletProperties(kamelet *Kamelet) bool {
return true
}
-func ValidKameletTemplate(kamelet *Kamelet) bool {
+func ValidKamelet(kamelet *Kamelet) bool {
Review Comment:
It just checks the kamelet is not nil. I guess we may need it in the future to provide more checks, but for now it really doesn't do that much. I may remove it at next iteration, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org