You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "milastdbx (via GitHub)" <gi...@apache.org> on 2024/10/24 09:25:03 UTC

Re: [PR] [SPARK-49695][SQL] Postgres fix xor push-down [spark]

milastdbx commented on code in PR #48144:
URL: https://github.com/apache/spark/pull/48144#discussion_r1814621792


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala:
##########
@@ -404,4 +404,26 @@ private case class PostgresDialect()
       case _ =>
     }
   }
+
+  override def compileExpression(expr: Expression): Option[String] = {
+    val builder = new PostgresSQLBuilder()
+    try {

Review Comment:
   perhaps its better to only override visitBinaryArithmetics?
   
   We have similar problem with some of the functions and we use `dialectFunctionName` to translate from Spark to local dialect



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org