You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/02/11 18:55:14 UTC

[GitHub] [accumulo] EdColeman commented on a change in pull request #1505: Optimize Tablet volume replacement

EdColeman commented on a change in pull request #1505: Optimize Tablet volume replacement
URL: https://github.com/apache/accumulo/pull/1505#discussion_r377831812
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
 ##########
 @@ -184,9 +184,8 @@ public static String switchRootTableVolume(String location) throws IOException {
    * for use it chooses a new tablet directory.
    */
   public static TabletFiles updateTabletVolumes(AccumuloServerContext context, ZooLock zooLock,
-      VolumeManager vm, KeyExtent extent, TabletFiles tabletFiles, boolean replicate)
-      throws IOException {
-    List<Pair<Path,Path>> replacements = ServerConstants.getVolumeReplacements();
+      VolumeManager vm, KeyExtent extent, TabletFiles tabletFiles, boolean replicate,
+      List<Pair<Path,Path>> replacements) throws IOException {
     log.trace("Using volume replacements: " + replacements);
 
 Review comment:
   Should the log statement be using parameter substitution? 
   `log.trace("Using volume replacements: {}" + replacements);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services