[GitHub] [ignite-3] xtern commented on a diff in pull request #1866: IGNITE-18984 Migrate JDBC batched methods on new internal API

["xtern (via GitHub)" <gi...@apache.org>]

xtern commented on code in PR #1866:
URL: https://github.com/apache/ignite-3/pull/1866#discussion_r1154228366


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -177,14 +177,14 @@ private QueryContext createQueryContext(JdbcStatementType stmtType) {
 
     /** {@inheritDoc} */
     @Override
-    public CompletableFuture<JdbcBatchExecuteResult> batchAsync(JdbcBatchExecuteRequest req) {
+    public CompletableFuture<JdbcBatchExecuteResult> batchAsync(long connectionId, JdbcBatchExecuteRequest req) {
         List<String> queries = req.queries();
 
         var counters = new IntArrayList(req.queries().size());
         var tail = CompletableFuture.completedFuture(counters);
 
         for (String query : queries) {
-            tail = tail.thenCompose(list -> executeAndCollectUpdateCount(req.schemaName(), query, OBJECT_EMPTY_ARRAY)

Review Comment:
   Do we still need `schemaName` field in JdbcBatchPreparedStmntRequest and JdbcBatchExecuteRequest?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org