You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2024/02/21 06:48:13 UTC
[PR] [fix](datetime) fix datetime round on BE [doris]
zhiqiang-hhhh opened a new pull request, #31205:
URL: https://github.com/apache/doris/pull/31205
```sql
with tmp as (
select CONCAT(
YEAR('2024-02-06 03:37:07.157'), '-',
LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
AS generated_string)
select generated_string, cast(generated_string as DateTime(6)) from tmp
```
before (incorrect round)
```
+-------------------------------+-----------------------------------------+
| generated_string | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456 |
+-------------------------------+-----------------------------------------+
```
after (round up, keep consistent with mysql):
```txt
+-------------------------------+-----------------------------------------+
| generated_string | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457 |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)
```
same work with #30744 but implemented on BE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1955998497
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1956020711
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1956020684
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1956007975
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1956024837
<details>
<summary>TPC-H: <b>Total hot run time: 41273 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit afd0540df96301fccc570198fbd103bbdea249f7, data reload: false
------ Round 1 ----------------------------------
q1 17622 4962 4836 4836
q2 2055 138 133 133
q3 10669 1008 988 988
q4 4774 935 952 935
q5 7726 3248 3256 3248
q6 193 132 133 132
q7 1244 772 772 772
q8 9394 2071 2069 2069
q9 7954 6708 6648 6648
q10 8360 2634 2621 2621
q11 432 205 196 196
q12 1109 320 348 320
q13 18052 3634 3642 3634
q14 289 261 254 254
q15 619 501 509 501
q16 521 408 418 408
q17 936 873 833 833
q18 7136 6624 6661 6624
q19 1702 1495 1655 1495
q20 567 337 347 337
q21 6154 3971 3953 3953
q22 388 351 336 336
Total cold run time: 107896 ms
Total hot run time: 41273 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4876 4811 4811 4811
q2 294 182 181 181
q3 3562 3555 3562 3555
q4 2512 2508 2505 2505
q5 5733 5702 5716 5702
q6 206 129 122 122
q7 2228 1638 1632 1632
q8 3006 3071 3094 3071
q9 8629 8695 8667 8667
q10 4130 4198 4217 4198
q11 507 380 352 352
q12 757 554 533 533
q13 4178 3371 3387 3371
q14 264 224 242 224
q15 580 510 501 501
q16 491 432 441 432
q17 1669 1574 1590 1574
q18 8359 7704 7722 7704
q19 1629 1633 1629 1629
q20 2132 1820 1825 1820
q21 6505 6092 6064 6064
q22 558 492 491 491
Total cold run time: 62805 ms
Total hot run time: 59139 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31205:
URL: https://github.com/apache/doris/pull/31205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1955998425
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](datetime) fix datetime round on BE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31205:
URL: https://github.com/apache/doris/pull/31205#issuecomment-1956027635
TeamCity be ut coverage result:
Function Coverage: 35.72% (8558/23959)
Line Coverage: 27.60% (69414/251541)
Region Coverage: 26.73% (36016/134746)
Branch Coverage: 23.55% (18422/78238)
Coverage Report: http://coverage.selectdb-in.cc/coverage/afd0540df96301fccc570198fbd103bbdea249f7_afd0540df96301fccc570198fbd103bbdea249f7/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org