You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2014/05/02 23:38:41 UTC

Review Request 21036: Implement aggregate functions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21036/
-----------------------------------------------------------

Review request for drill and Aman Sinha.


Bugs: DRILL-556
    https://issues.apache.org/jira/browse/DRILL-556


Repository: drill-git


Description
-------

Updated patch with review comment. Link to the original pull request: https://github.com/apache/incubator-drill/pull/56

Implements standard deviation, variance, var_samp, stddev_samp.
Also added aggregate functions: max, min, count, sum, avg from Date and Interval data types.

Patch is based on DRILL-549 (attached as a parent diff)


Diffs
-----

  exec/java-exec/src/main/codegen/config.fmpp 49e0614 
  exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 25dcd96 
  exec/java-exec/src/main/codegen/data/AggrTypes2.tdd a05d074 
  exec/java-exec/src/main/codegen/data/AggrTypes3.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java 14ca1ce 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java f2ebbe8 
  exec/java-exec/src/main/codegen/templates/AggrTypeFunctions3.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/DateIntervalAggrFunctions1.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/IntervalAggrFunctions2.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateUtility.java c9e66a1 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunction.java PRE-CREATION 
  exec/java-exec/src/test/resources/functions/test_stddev_variance.json PRE-CREATION 
  exec/java-exec/src/test/resources/simple_stddev_variance_input.json PRE-CREATION 
  sqlparser/src/test/java/org/apache/drill/jdbc/test/TestDateAggregateFunction.java PRE-CREATION 

Diff: https://reviews.apache.org/r/21036/diff/


Testing
-------

Added tests to TestDateAggregateFunction and TestAggregateFunction.


Thanks,

Mehant Baid