You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/09 01:40:26 UTC
[GitHub] [dubbo-go] flycash commented on a change in pull request #506: add the comment of ConsistentHash
flycash commented on a change in pull request #506:
URL: https://github.com/apache/dubbo-go/pull/506#discussion_r422438610
##########
File path: cluster/loadbalance/consistent_hash.go
##########
@@ -85,22 +85,25 @@ func (lb *ConsistentHashLoadBalance) Select(invokers []protocol.Invoker, invocat
return selector.Select(invocation)
}
-// Uint32Slice ...
+// Uint32Slice Slice of uint32
type Uint32Slice []uint32
Review comment:
please move this to gost. We already have similar structure...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org