You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/28 01:22:04 UTC

[GitHub] [spark] JoshRosen commented on pull request #36680: [SPARK-39283][CORE] Fix deadlock between TaskMemoryManager and UnsafeExternalSorter.SpillableIterator

JoshRosen commented on PR #36680:
URL: https://github.com/apache/spark/pull/36680#issuecomment-1140129567

   > I believe we can do it without having a local `inMemSorterToFree`
   
   I considered that but didn't suggest it because I thought it was more complex to reason about (since we need to think about other potential accesses and assignments to that field, vs. only having to reason locally about the single method being changed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org