You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Jira)" <ji...@apache.org> on 2021/05/06 23:32:00 UTC
[jira] [Comment Edited] (CASSANDRA-14701) Cleanup (and other)
compaction type(s) not counted in compaction remaining time
[ https://issues.apache.org/jira/browse/CASSANDRA-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340478#comment-17340478 ]
Brandon Williams edited comment on CASSANDRA-14701 at 5/6/21, 11:31 PM:
------------------------------------------------------------------------
||Branch||CI||
|[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-3.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/751/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/751/pipeline]|
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-3.11]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/746/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/746/pipeline]|
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/747/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/747/pipeline]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-14701]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/748/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/748/pipeline]|
The good news is, this is a cosmetic decision/bug in nodetool only. I did some git spelunking to see if there was any reasoning behind it, and it goes all the way back to inception in CASSANDRA-4167 which doesn't go into depth. I don't see any reason for it to do this, especially this way, since all it does is make the calculations incorrect for other compaction types.
was (Author: brandon.williams):
||Branch||CI||
|[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-3.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/745/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/745/pipeline]|
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-3.11]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/746/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/746/pipeline]|
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-14701-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/747/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/747/pipeline]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-14701]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/748/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/748/pipeline]|
The good news is, this is a cosmetic decision/bug in nodetool only. I did some git spelunking to see if there was any reasoning behind it, and it goes all the way back to inception in CASSANDRA-4167 which doesn't go into depth. I don't see any reason for it to do this, especially this way, since all it does is make the calculations incorrect for other compaction types.
> Cleanup (and other) compaction type(s) not counted in compaction remaining time
> -------------------------------------------------------------------------------
>
> Key: CASSANDRA-14701
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14701
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability
> Reporter: Thomas Steinmaurer
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Opened a ticket, as discussed in user list.
> Looks like compaction remaining time only includes compactions of type COMPACTION and other compaction types like cleanup etc. aren't part of the estimation calculation.
> E.g. from one of our environments:
> {noformat}
> nodetool compactionstats -H
> pending tasks: 1
> compaction type keyspace table completed total unit progress
> Cleanup XXX YYY 908.16 GB 1.13 TB bytes 78.63%
> Active compaction remaining time : 0h00m00s
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org