[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572010794



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
     if (value == null) {
       localProperties.get.remove(key)
     } else {
+      checkLocalProperty(key, value)

Review comment:
       Do we expect users would set `spark.job.interruptOnCance` as I notice it's private? I think it may be better to prevent users from setting this kind of private property instead of doing check valid check.  And we could recommend users to use `setJobGroup` instead.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org