You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2021/05/03 07:51:01 UTC

[zeppelin] 01/02: [ZEPPELIN-5296]. NPE when calling completion for %spark.sql

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/zeppelin.git

commit c01dc398a6892a2346fbff008b9f6d9ebb56997d
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Tue Mar 23 15:00:14 2021 +0800

    [ZEPPELIN-5296]. NPE when calling completion for %spark.sql
    
    ### What is this PR for?
    
    Trivial PR to fix NPE in Spark interpreter when calling code completion.
    
    ### What type of PR is it?
    [Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-5296
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #4084 from zjffdu/ZEPPELIN-5296 and squashes the following commits:
    
    89bbe4e9a [Jeff Zhang] [ZEPPELIN-5296]. NPE when calling completion for %spark.sql
---
 .../main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java    | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java b/spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java
index cd82878..6c06399 100644
--- a/spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java
+++ b/spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java
@@ -188,10 +188,4 @@ public class SparkSqlInterpreter extends AbstractInterpreter {
       }
     }
   }
-
-  @Override
-  public List<InterpreterCompletion> completion(String buf, int cursor,
-      InterpreterContext interpreterContext) {
-    return null;
-  }
 }