[GitHub] [sling-org-apache-sling-testing-resourceresolver-mock] stefanseifert commented on pull request #8: SLING-11455 ResourceProvider implementation

[GitBox <gi...@apache.org>]

stefanseifert commented on PR #8:
URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/8#issuecomment-1185716241

   i've to pause the further work on this PR a bit. it basically looks quite good and seems to work as expected.
   
   what's left to do:
   * we need a new solution for providing mocked query results when using as ResourceProvider. this is related to [SLING-11252](https://issues.apache.org/jira/browse/SLING-11252)
   * add unit tests for more complex scenarios with multiple resource providers
   * the wrapping of MockResourceResolver inside MockResouceProvider required some tweaks and hacks. it would make sense to split the actual mocked resource persistence from MockResouceResolver into a separate class (e.g. MockResourcePersistence), and use that from MockResourceResolver and MockResouceProvider instead of the wrapping. but this can also be done later separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org