You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Rubueno (via GitHub)" <gi...@apache.org> on 2024/12/13 13:11:15 UTC

[PR] fix typo in SnapshotManager.java [cloudstack]

Rubueno opened a new pull request, #10104:
URL: https://github.com/apache/cloudstack/pull/10104

   ### Description
   
   This PR fixes a typo
   
   ### Types of changes
   
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### How Has This Been Tested?
   
   No testing required for a typo fix.
   
   #### How did you try to break this feature and the system with this change?
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix typo in SnapshotManager.java [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10104:
URL: https://github.com/apache/cloudstack/pull/10104#issuecomment-2541739051

   config key description only, let's wait for github actions and merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix typo in SnapshotManager.java [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10104:
URL: https://github.com/apache/cloudstack/pull/10104#issuecomment-2543183767

   UI build error is unrelated (annoying though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix typo in SnapshotManager.java [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10104:
URL: https://github.com/apache/cloudstack/pull/10104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix typo in SnapshotManager.java [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10104:
URL: https://github.com/apache/cloudstack/pull/10104#issuecomment-2541828419

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10104?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 16.90%. Comparing base [(`91ab67c`)](https://app.codecov.io/gh/apache/cloudstack/commit/91ab67c9522326217fdef34631d15c697a7c9de6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`77d6d2c`)](https://app.codecov.io/gh/apache/cloudstack/commit/77d6d2c2ffe93a6353632b589dc10a493187c7ae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main   #10104      +/-   ##
   ============================================
   + Coverage     16.06%   16.90%   +0.84%     
     Complexity    12864    12864              
   ============================================
     Files          5642     5248     -394     
     Lines        493856   461495   -32361     
     Branches      59860    54147    -5713     
   ============================================
   - Hits          79326    78023    -1303     
   + Misses       405749   374838   -30911     
   + Partials       8781     8634     -147     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10104/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.90% <100.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10104?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org