You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 10:00:51 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10842: fix(test): missing auth on tests
dpgaspar opened a new pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#issuecomment-691074858
> Nice catch 👍 LGTM, but I wonder if we should standardize on how `self.login` is called. It appears the test codebase is mostly calling `self.login("admin")`, which is the exact same as `self.login()` due to defaults. I wonder if we should just make it mandatory to specify the username?
Yes, agree we should standardize, I'm planning on making of bunch of PR's to refactor tests to use pytest fixtures also, it may make sense to include that on those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#discussion_r486996204
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#discussion_r486996204
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#issuecomment-691074858
> Nice catch 👍 LGTM, but I wonder if we should standardize on how `self.login` is called. It appears the test codebase is mostly calling `self.login("admin")`, which is the exact same as `self.login()` due to defaults. I wonder if we should just make it mandatory to specify the username?
Yes, agree we should standardize, I'm planning on making of bunch of PR's to refactor tests to use pytest fixtures also, it may make sense to include that on those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#issuecomment-691074858
> Nice catch 👍 LGTM, but I wonder if we should standardize on how `self.login` is called. It appears the test codebase is mostly calling `self.login("admin")`, which is the exact same as `self.login()` due to defaults. I wonder if we should just make it mandatory to specify the username?
Yes, agree we should standardize, I'm planning on making of bunch of PR's to refactor tests to use pytest fixtures also, it may make sense to include that on those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#issuecomment-691074858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10842: fix(test): missing auth on tests
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10842:
URL: https://github.com/apache/incubator-superset/pull/10842#discussion_r486996204
##########
File path: tests/core_tests.py
##########
@@ -952,44 +955,47 @@ def test_get_select_star_not_allowed(self):
@mock.patch("superset.views.core.results_backend_use_msgpack", False)
@mock.patch("superset.views.core.results_backend")
- @mock.patch("superset.views.core.db")
- def test_display_limit(self, mock_superset_db, mock_results_backend):
- query_mock = mock.Mock()
- query_mock.sql = "SELECT *"
- query_mock.database = 1
- query_mock.schema = "superset"
- mock_superset_db.session.query().filter_by().one_or_none.return_value = (
- query_mock
- )
+ def test_display_limit(self, mock_results_backend):
+ self.login()
data = [{"col_0": i} for i in range(100)]
payload = {
"status": utils.QueryStatus.SUCCESS,
"query": {"rows": 100},
"data": data,
}
+ # limit results to 1
+ expected_key = {"status": "success", "query": {"rows": 100}, "data": data}
+ limited_data = data[:1]
+ expected_limited = {
+ "status": "success",
+ "query": {"rows": 100},
+ "data": limited_data,
+ "displayLimitReached": True,
+ }
+
+ query_mock = mock.Mock()
+ query_mock.sql = "SELECT *"
+ query_mock.database = 1
+ query_mock.schema = "superset"
+
# do not apply msgpack serialization
use_msgpack = app.config["RESULTS_BACKEND_USE_MSGPACK"]
app.config["RESULTS_BACKEND_USE_MSGPACK"] = False
serialized_payload = sql_lab._serialize_payload(payload, False)
compressed = utils.zlib_compress(serialized_payload)
mock_results_backend.get.return_value = compressed
- # get all results
- result = json.loads(self.get_resp("/superset/results/key/"))
- expected = {"status": "success", "query": {"rows": 100}, "data": data}
- self.assertEqual(result, expected)
+ with mock.patch("superset.views.core.db") as mock_superset_db:
Review comment:
using the mock has a decorator was mocking for `self.login()` also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org