You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/10 23:37:00 UTC
[jira] [Commented] (SAMZA-1947) Remove specific js/css files from
rat excludes
[ https://issues.apache.org/jira/browse/SAMZA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645713#comment-16645713 ]
ASF GitHub Bot commented on SAMZA-1947:
---------------------------------------
GitHub user shanthoosh opened a pull request:
https://github.com/apache/samza/pull/703
SAMZA-1947: Remove specific js/css files from rat excludes
Internally at Linkedin we've observed that excluding specific `js` and `css` through rat gradle-plugin causes the ligradle build to not run the unit-tests.
To fix it, this patch removes those files from rat excludes and adds the samza license to the individual files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shanthoosh/samza master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/703.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #703
----
commit 085c4ec539cd6157203ca93714af5f59435ac236
Author: Shanthoosh Venkataraman <sp...@...>
Date: 2018-10-10T23:22:57Z
Remove specific rat excludes.
----
> Remove specific js/css files from rat excludes
> ----------------------------------------------
>
> Key: SAMZA-1947
> URL: https://issues.apache.org/jira/browse/SAMZA-1947
> Project: Samza
> Issue Type: New Feature
> Reporter: Shanthoosh Venkataraman
> Assignee: Shanthoosh Venkataraman
> Priority: Minor
>
> Internally at Linkedin we've observed that excluding specific `js` and `css` through rat gradle-plugin causes the ligradle build to not run the unit-tests.
> To fix it, this patch removes those files from rat excludes and adds the samza license to the individual files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)