You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/01 01:28:35 UTC

[GitHub] [spark] wzhfy edited a comment on pull request #29594: [SPARK-32754][SQL][TEST] Unify `assertEqualPlans` for join reorder suites

wzhfy edited a comment on pull request #29594:
URL: https://github.com/apache/spark/pull/29594#issuecomment-684136749


   @cloud-fan @dongjoon-hyun 
   I have renamed the method `assertEqualPlans` to `assertEqualJoinPlans`, and moved `compareJoinOrder` and `sameJoinPlan` from `PlanTest` to `JoinReorderPlanTestBase` since they are only used in join reorder test suites.
   Could you please take another look? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org