You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "PDGGK (via GitHub)" <gi...@apache.org> on 2026/02/05 19:07:22 UTC
[PR] [Java SDK] Warn when ValueState contains collection types [beam]
PDGGK opened a new pull request, #37523:
URL: https://github.com/apache/beam/pull/37523
## Summary
This PR adds a warning when users declare `ValueState` with collection types (`Map`, `List`, `Set`) that could benefit from using specialized state types for better performance.
**Problem:**
When users store collections in `ValueState`, the entire collection must be read and written on each access. This can cause significant performance issues for large collections.
**Solution:**
Log a warning during pipeline construction suggesting:
- `ValueState<Map>` → Use `MapState` instead
- `ValueState<List>` → Use `BagState` or `OrderedListState` instead
- `ValueState<Set>` → Use `SetState` instead
**Changes:**
- `DoFnSignatures.java`: Added `warnIfValueStateContainsCollection()` method that inspects state declarations and logs warnings for collection types
- `DoFnSignaturesTest.java`: Added test cases to verify the warning logic works correctly
Fixes #36746
## Test plan
- [x] Added tests for `ValueState<Map>`, `ValueState<List>`, `ValueState<Set>`
- [x] Added test for simple `ValueState<String>` (no warning expected)
- [ ] Existing tests should continue to pass
---
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java SDK] Warn when ValueState contains collection types [beam]
Posted by "PDGGK (via GitHub)" <gi...@apache.org>.
PDGGK commented on PR #37523:
URL: https://github.com/apache/beam/pull/37523#issuecomment-3857568183
Closing to recreate with clean branch (previous branch had unrelated Iceberg changes mixed in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java SDK] Warn when ValueState contains collection types [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37523:
URL: https://github.com/apache/beam/pull/37523#issuecomment-3855651166
## Summary of Changes
Hello @PDGGK, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request improves developer guidance in the Apache Beam Java SDK by introducing a warning for inefficient `ValueState` usage with collection types, promoting better performance through specialized state. Concurrently, it refines the Iceberg I/O connector's schema projection to correctly process nested column paths during field dropping, enhancing data filtering accuracy.
### Highlights
* **ValueState Collection Warning**: Introduced a new warning in `DoFnSignatures` to alert users when `ValueState` is declared with collection types (Map, List, Set), recommending specialized state types for performance.
* **Iceberg Nested Column Pruning**: Enhanced Iceberg connector's schema projection to accurately handle dropping nested columns, ensuring only specified fields and their children are excluded.
* **New Unit Tests for ValueState Warnings**: Added comprehensive unit tests for the new `ValueState` collection warning logic, covering various collection types and simple types.
* **New Tests for Iceberg Nested Column Pruning**: Included new tests for Iceberg I/O to validate correct behavior of nested column pruning with both `keep` and `drop` configurations.
🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Changelog</b></summary>
* **sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java**
* Integrated SLF4J logging.
* Added `warnIfValueStateContainsCollection` method to identify and log warnings for `ValueState` instances holding `Map`, `List`, or `Set` types, suggesting `MapState`, `BagState`/`OrderedListState`, or `SetState` respectively.
* Invoked the new warning method during the analysis of state declarations.
* **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java**
* Introduced new `DoFn` classes for testing `ValueState` with `Map`, `List`, `Set`, and `String` types.
* Added test methods (`testValueStateWithMapLogsWarning`, `testValueStateWithListLogsWarning`, `testValueStateWithSetLogsWarning`, `testValueStateWithSimpleTypeNoWarning`) to verify the warning mechanism's behavior.
* **sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergScanConfig.java**
* Updated the `resolveSchema` method to correctly handle `drop` configurations for nested fields. It now identifies leaf fields and removes them or their children based on the `drop` list, preventing unintended dropping of parent structs.
* Modified the `validate` method to use `table.schema().findField(name)` for validating dropped fields, allowing support for nested column paths (e.g., "colA.colB").
* **sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/IcebergIOReadTest.java**
* Added `testNestedColumnPruningValidation` to confirm that nested column paths are correctly handled when specified in the `keep` configuration.
* Added `testNestedColumnDropValidation` to ensure that dropping nested fields works as expected, verifying that the specified nested field is removed from the projected schema.
</details>
<details>
<summary><b>Activity</b></summary>
* Tests were added for `ValueState` with `Map`, `List`, and `Set` collection types.
* A test was included for `ValueState` with a simple `String` type, expecting no warning.
* The author confirmed that existing tests should continue to pass.
* The PR description indicates it was generated with Claude Code.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java SDK] Warn when ValueState contains collection types [beam]
Posted by "PDGGK (via GitHub)" <gi...@apache.org>.
PDGGK closed pull request #37523: [Java SDK] Warn when ValueState contains collection types
URL: https://github.com/apache/beam/pull/37523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java SDK] Warn when ValueState contains collection types [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37523:
URL: https://github.com/apache/beam/pull/37523#issuecomment-3856425727
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org