You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/25 05:39:18 UTC
Review Request 55030: CMake: Added source groups for libprocess build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Bugs: MESOS-3542
https://issues.apache.org/jira/browse/MESOS-3542
Repository: mesos
Description
-------
Currently in IDEs such as XCode and Visual Studio, all mesos source
files are grouped into one huge folder, with no attempt made to reflect
the hierarchy of folders that exist on disk.
This commit groups libprocess files into relevant source groups so that
they appear in a sensible directory structure in these IDEs.
In addition to beginning to directly address MESOS-3542, this is also
(indirectly) the first step towards addressing the problem of breaking
libmesos up into smaller binaries (MESOS-3542).
Diffs
-----
3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046
3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55
3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
Diff: https://reviews.apache.org/r/55030/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 11, 2017, 10:23 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt, lines 80-81
> > <https://reviews.apache.org/r/55030/diff/1/?file=1591744#file1591744line80>
> >
> > What's the effect of adding these `source_groups` in multiple CMake lists?
> >
> > Is the only effect that each subproject in MSVC will show the files in an organized way?
The effect is that they're organized in every IDE, not just VS.
(Also, please let me know if the commit message needs to be massaged for this to make sense.)
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review161306
-----------------------------------------------------------
On Dec. 25, 2016, 5:39 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55030/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2016, 5:39 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-3542
> https://issues.apache.org/jira/browse/MESOS-3542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
>
> This commit groups libprocess files into relevant source groups so that
> they appear in a sensible directory structure in these IDEs.
>
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046
> 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review161306
-----------------------------------------------------------
3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines 59 - 72)
<https://reviews.apache.org/r/55030/#comment232546>
s/Process/Libprocess/
^ Not in the path, only in the first argument of `source_group`.
Even if the "lib" part is a unix semantic, the full name of this 3rdparty library is "libprocess".
3rdparty/libprocess/src/CMakeLists.txt (lines 72 - 78)
<https://reviews.apache.org/r/55030/#comment232537>
There are two other SSL .cpp files:
* openssl.cpp
* libevent_ssl_socket.cpp
Note that these are not in the `ssl` subfolder.
3rdparty/libprocess/src/CMakeLists.txt (line 140)
<https://reviews.apache.org/r/55030/#comment232548>
s/Process/Libprocess/
3rdparty/libprocess/src/tests/CMakeLists.txt (lines 80 - 81)
<https://reviews.apache.org/r/55030/#comment232552>
What's the effect of adding these `source_groups` in multiple CMake lists?
Is the only effect that each subproject in MSVC will show the files in an organized way?
- Joseph Wu
On Dec. 24, 2016, 9:39 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55030/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 9:39 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-3542
> https://issues.apache.org/jira/browse/MESOS-3542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
>
> This commit groups libprocess files into relevant source groups so that
> they appear in a sensible directory structure in these IDEs.
>
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046
> 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 25, 2017, 12:29 a.m., Joseph Wu wrote:
> > This review is partially un-done by https://reviews.apache.org/r/55604/ . Can you separate the source-grouping changes into https://reviews.apache.org/r/55604/ ? And leave the CMake lists rearrangement in this review?
We still need this change because we need to add the `.hpp` files to the call to `add_executable` in order for them to show up as source groups. I've rebased to account for your recent changes.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review162883
-----------------------------------------------------------
On Jan. 29, 2017, 7:18 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55030/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2017, 7:18 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-3542
> https://issues.apache.org/jira/browse/MESOS-3542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
>
> This commit groups libprocess files into relevant source groups so that
> they appear in a sensible directory structure in these IDEs.
>
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/CMakeLists.txt ab362aa476e528deef691239a70f0be9d864e6c0
> 3rdparty/libprocess/src/tests/CMakeLists.txt b298bbe042cabcb18169da1923562e9956374232
>
> Diff: https://reviews.apache.org/r/55030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review162883
-----------------------------------------------------------
This review is partially un-done by https://reviews.apache.org/r/55604/ . Can you separate the source-grouping changes into https://reviews.apache.org/r/55604/ ? And leave the CMake lists rearrangement in this review?
- Joseph Wu
On Jan. 15, 2017, 12:47 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55030/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 12:47 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-3542
> https://issues.apache.org/jira/browse/MESOS-3542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
>
> This commit groups libprocess files into relevant source groups so that
> they appear in a sensible directory structure in these IDEs.
>
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046
> 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55
> 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351
>
> Diff: https://reviews.apache.org/r/55030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 11:04 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Changes
-------
Rebase to account for changes in `master`.
Bugs: MESOS-3542
https://issues.apache.org/jira/browse/MESOS-3542
Repository: mesos
Description
-------
Currently in IDEs such as XCode and Visual Studio, all mesos source
files are grouped into one huge folder, with no attempt made to reflect
the hierarchy of folders that exist on disk.
This commit groups libprocess files into relevant source groups so that
they appear in a sensible directory structure in these IDEs.
In addition to beginning to directly address MESOS-3542, this is also
(indirectly) the first step towards addressing the problem of breaking
libmesos up into smaller binaries (MESOS-3542).
Diffs (updated)
-----
3rdparty/libprocess/src/CMakeLists.txt ab362aa476e528deef691239a70f0be9d864e6c0
3rdparty/libprocess/src/tests/CMakeLists.txt c65c7f5a97817f4a790136e97eb9f02c0bf810b9
Diff: https://reviews.apache.org/r/55030/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 7:18 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Changes
-------
Rebase against current HEAD.
Bugs: MESOS-3542
https://issues.apache.org/jira/browse/MESOS-3542
Repository: mesos
Description
-------
Currently in IDEs such as XCode and Visual Studio, all mesos source
files are grouped into one huge folder, with no attempt made to reflect
the hierarchy of folders that exist on disk.
This commit groups libprocess files into relevant source groups so that
they appear in a sensible directory structure in these IDEs.
In addition to beginning to directly address MESOS-3542, this is also
(indirectly) the first step towards addressing the problem of breaking
libmesos up into smaller binaries (MESOS-3542).
Diffs (updated)
-----
3rdparty/libprocess/src/CMakeLists.txt ab362aa476e528deef691239a70f0be9d864e6c0
3rdparty/libprocess/src/tests/CMakeLists.txt b298bbe042cabcb18169da1923562e9956374232
Diff: https://reviews.apache.org/r/55030/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55030: CMake: Added source groups for libprocess
build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/
-----------------------------------------------------------
(Updated Jan. 15, 2017, 8:47 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Bugs: MESOS-3542
https://issues.apache.org/jira/browse/MESOS-3542
Repository: mesos
Description
-------
Currently in IDEs such as XCode and Visual Studio, all mesos source
files are grouped into one huge folder, with no attempt made to reflect
the hierarchy of folders that exist on disk.
This commit groups libprocess files into relevant source groups so that
they appear in a sensible directory structure in these IDEs.
In addition to beginning to directly address MESOS-3542, this is also
(indirectly) the first step towards addressing the problem of breaking
libmesos up into smaller binaries (MESOS-3542).
Diffs (updated)
-----
3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046
3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55
3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351
Diff: https://reviews.apache.org/r/55030/diff/
Testing
-------
Thanks,
Alex Clemmer