Re: [PR] Handling exit of kerberos sidecar container for k8s < 1.28 [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #35748:
URL: https://github.com/apache/airflow/pull/35748#discussion_r1421827060


##########
chart/templates/_helpers.yaml:
##########
@@ -997,3 +997,27 @@ capabilities:
             app: keda-operator
   {{- end }}
 {{- end }}
+
+{{- define "kubernetesVersion" -}}
+{{ printf "%s" .Capabilities.KubeVersion.Version | trimPrefix "v" }}
+{{- end -}}
+
+{{- define "airflowKerberosContainerArgs" -}}
+{{- $kubectl_version := include "kubernetesVersion" . -}}
+{{- if and (semverCompare ">=2.8.0" .Values.airflowVersion) (semverCompare "<1.28" $kubectl_version) }}

Review Comment:
   We need unit tests as well. But I wonder - why `Airflow >=2.8.0` ? We d o not seem to add any functionality for that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org