You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 22:10:34 UTC
[GitHub] [beam] andoni-guzman opened a new pull request, #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
andoni-guzman opened a new pull request, #23112:
URL: https://github.com/apache/beam/pull/23112
This PR is part of the migration from jenkins to github actions.
This PR contains this tests
Java PostCommit Nexmark Direct
Java PostCommit Nexmark Flink
Java PostCommit Nexmark Spark
3 Files were added to the workflows folder of github actions
- job-postcommit-java-nexmark-direct and
- job-postcommit-java-nexmark-flink
- job-postcommit-java-nexmark-spark
3 Files were deleted, this files were the groovy files for jenkins
- Nexmark Direct
- Nexmark Flink
- Nexmark Spark
-
Jenkins readme was modified deleting migrated tests.
CI.md was modified adding the new GA workflows
Waiting for this PR before merge https://github.com/apache/beam/pull/22703
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on a diff in pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on code in PR #23112:
URL: https://github.com/apache/beam/pull/23112#discussion_r995957438
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
+ BIGQUERYDATASET: nexmark
+ PROJECT: apache-beam-testing
+ RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE
+ EXPORTSUMMARYTOBIGQUERY: true
+ TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark
+ INFLUXDATABASE: beam_test_metrics
+ INFLUXHOST: http://10.128.0.96:8086
+ BASEINFLUXMEASUREMENT: nexmark
+ EXPORTSUMMARYTOINFLUXDB: true
+ INFLUXRETENTIONPOLICY: forever
+
+jobs:
+ java-postcommit-nexmark-direct:
+ name: Run PostCommit Java Nexmark - Direct Runner
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ timeout-minutes: 240
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL STREAM MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN ZETASQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=zetasql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: RUN *** NEXMARK IN ZETASQL STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
Review Comment:
Working in the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23112:
URL: https://github.com/apache/beam/pull/23112#discussion_r995908636
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
+ BIGQUERYDATASET: nexmark
+ PROJECT: apache-beam-testing
+ RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE
+ EXPORTSUMMARYTOBIGQUERY: true
+ TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark
+ INFLUXDATABASE: beam_test_metrics
+ INFLUXHOST: http://10.128.0.96:8086
+ BASEINFLUXMEASUREMENT: nexmark
+ EXPORTSUMMARYTOINFLUXDB: true
+ INFLUXRETENTIONPOLICY: forever
+
+jobs:
+ java-postcommit-nexmark-direct:
+ name: Run PostCommit Java Nexmark - Direct Runner
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ timeout-minutes: 240
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL STREAM MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN ZETASQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=zetasql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: RUN *** NEXMARK IN ZETASQL STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
Review Comment:
Is the only difference here the streaming variable and the queryLanguage? If so, can we just make these separate jobs and use a matrix to run with each variable type?
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
+ BIGQUERYDATASET: nexmark
+ PROJECT: apache-beam-testing
+ RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE
+ EXPORTSUMMARYTOBIGQUERY: true
+ TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark
+ INFLUXDATABASE: beam_test_metrics
+ INFLUXHOST: http://10.128.0.96:8086
+ BASEINFLUXMEASUREMENT: nexmark
+ EXPORTSUMMARYTOINFLUXDB: true
+ INFLUXRETENTIONPOLICY: forever
+
+jobs:
+ java-postcommit-nexmark-direct:
+ name: Run PostCommit Java Nexmark - Direct Runner
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ timeout-minutes: 240
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***
Review Comment:
Same comment applies elsewhere - please remove bold/all caps
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
Review Comment:
These environment variables are used in a number of workflows. Should we refactor them to our shared variable config?
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
+ BIGQUERYDATASET: nexmark
+ PROJECT: apache-beam-testing
+ RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE
+ EXPORTSUMMARYTOBIGQUERY: true
+ TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark
+ INFLUXDATABASE: beam_test_metrics
+ INFLUXHOST: http://10.128.0.96:8086
+ BASEINFLUXMEASUREMENT: nexmark
+ EXPORTSUMMARYTOINFLUXDB: true
+ INFLUXRETENTIONPOLICY: forever
+
+jobs:
+ java-postcommit-nexmark-direct:
+ name: Run PostCommit Java Nexmark - Direct Runner
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ timeout-minutes: 240
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN SQL STREAM MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: Run *** RUN NEXMARK IN ZETASQL BATCH MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=zetasql
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
+ - name: RUN *** NEXMARK IN ZETASQL STREAMING MODE USING DIRECT RUNNER ***
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: >
+ :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --bigQueryTable=$BIGQUERYTABLE
+ --bigQueryDataset=$BIGQUERYDATASET
+ --project=$PROJECT
+ --resourceNameMode=$RESOURCENAMEMODE
+ --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY
+ --tempLocation=$TEMPLOCATION
+ --influxDatabase=$INFLUXDATABASE
+ --influxHost=$INFLUXHOST
+ --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT
+ --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB
+ --influxRetentionPolicy=$INFLUXRETENTIONPOLICY
+ --queryLanguage=sql
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true "
Review Comment:
Same comment applies below in the other workflows. In fact, if the runner is the only difference, we could probably just consolidate to a single workflow and use matrix builds on the runner.
##########
.github/workflows/job-postcommit-java-nexmark-direct.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Nexmark tests using Direct Runner.
+
+name: PostCommit Java Nexmark Direct Runner
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+permissions: read-all
+
+env:
+ BIGQUERYTABLE: nexmark
+ BIGQUERYDATASET: nexmark
+ PROJECT: apache-beam-testing
+ RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE
+ EXPORTSUMMARYTOBIGQUERY: true
+ TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark
+ INFLUXDATABASE: beam_test_metrics
+ INFLUXHOST: http://10.128.0.96:8086
+ BASEINFLUXMEASUREMENT: nexmark
+ EXPORTSUMMARYTOINFLUXDB: true
+ INFLUXRETENTIONPOLICY: forever
+
+jobs:
+ java-postcommit-nexmark-direct:
+ name: Run PostCommit Java Nexmark - Direct Runner
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ timeout-minutes: 240
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER ***
Review Comment:
```suggestion
- name: Run Nexmark in Batch mode on the direct runner
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1272305341
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1258630257
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
URL: https://github.com/apache/beam/pull/23112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1291942325
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1396922628
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1486823913
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1252715028
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #23112: GA Migration Java PostCommit Nexmark Direct, Flink, Spark
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #23112:
URL: https://github.com/apache/beam/pull/23112#issuecomment-1283164931
Hi @damccorm
I made some changes in this PR
- I use the test-properties file to get all the variables in all the tests of this PR.
- All the tests are now using a matrix,
- In the case of the tests related with spark, I use 2 jobs, the reason that are in different jobs in the workflow and not in a matrix are that the runner are different and one runner needs a special flag to work, using this in a matrix cause the failures of the pipeline, for example using the runner SparkRunner with the configuration of SparkStructuredStreamingRunner
If some changes are needed please let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org