You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/03/11 00:41:06 UTC
Review Request 18996: Fix errors in jobs.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
Fix errors in jobs.py.
Diffs
-----
src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
Diff: https://reviews.apache.org/r/18996/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 18996: Fix errors in jobs.py.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/#review36733
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/18996/#comment67853>
Mind adding a test case for this one?
- Maxim Khutornenko
On March 10, 2014, 11:44 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18996/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 11:44 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix errors in jobs.py.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
>
> Diff: https://reviews.apache.org/r/18996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 18996: Fix errors in jobs.py.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/#review36791
-----------------------------------------------------------
Thanks for following up!
- Maxim Khutornenko
On March 11, 2014, 4:12 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18996/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 4:12 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix errors in jobs.py.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
> src/test/python/apache/aurora/client/cli/test_status.py c543f3d903fbd216e7ebf03fda6c76da178a0f67
>
> Diff: https://reviews.apache.org/r/18996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 18996: Fix errors in jobs.py.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/#review36792
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 11, 2014, 4:12 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18996/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 4:12 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix errors in jobs.py.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
> src/test/python/apache/aurora/client/cli/test_status.py c543f3d903fbd216e7ebf03fda6c76da178a0f67
>
> Diff: https://reviews.apache.org/r/18996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 18996: Fix errors in jobs.py.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/
-----------------------------------------------------------
(Updated March 11, 2014, 12:12 p.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Add a regression test of the packages=None bug.
Repository: aurora
Description
-------
Fix errors in jobs.py.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
src/test/python/apache/aurora/client/cli/test_status.py c543f3d903fbd216e7ebf03fda6c76da178a0f67
Diff: https://reviews.apache.org/r/18996/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 18996: Fix errors in jobs.py.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18996/
-----------------------------------------------------------
(Updated March 10, 2014, 7:44 p.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Another glitch found - since this isn't review yet, might at well toss it in.
Repository: aurora
Description
-------
Fix errors in jobs.py.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44
Diff: https://reviews.apache.org/r/18996/diff/
Testing
-------
Thanks,
Mark Chu-Carroll