You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/04 06:57:43 UTC

[GitHub] [flink] hequn8128 opened a new pull request #11013: [hotfix][doc] Fix version settings when building PyFlink

hequn8128 opened a new pull request #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013
 
 
   
   ## What is the purpose of the change
   
   Due to the problem in [FLINK-15638](https://issues.apache.org/jira/browse/FLINK-15638), this pull request tries to fix the building errors by adding extra version settings.
   
   ## Brief change log
   
     - Adds extra version settings for PyFlink build documentation.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581778365
 
 
   <!--
   Meta data
   Hash:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a
   -->
   ## CI report:
   
   * 82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581774652
 
 
   @hequn8128 Thanks for the PR. LGTM, merging...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581778365
 
 
   <!--
   Meta data
   Hash:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331394 TriggerType:PUSH TriggerID:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a
   -->
   ## CI report:
   
   * 82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331394) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581789272
 
 
   @dianfu Thanks a lot for the review. Merging...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581770431
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a (Tue Feb 04 07:00:36 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
dianfu edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581774652
 
 
   @hequn8128 Thanks for the PR. LGTM. +1 to merge

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11013: [hotfix][doc] Fix version settings when building PyFlink
URL: https://github.com/apache/flink/pull/11013#issuecomment-581778365
 
 
   <!--
   Meta data
   Hash:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147331394 TriggerType:PUSH TriggerID:82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a
   -->
   ## CI report:
   
   * 82ec948ab5c2131c5ee0698fd96a3dfbdbe0ee2a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147331394) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services