[GitHub] [hbase] virajjasani commented on a change in pull request #812: HBASE-23275: Track active master's address in ActiveMasterManager

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #812: HBASE-23275: Track active master's address in ActiveMasterManager
URL: https://github.com/apache/hbase/pull/812#discussion_r344727120
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
 ##########
 @@ -178,10 +214,14 @@ boolean blockUntilBecomingActiveMaster(
           // We are the master, return
           startupStatus.setStatus("Successfully registered as active master.");
           this.clusterHasActiveMaster.set(true);
+          activeMasterServerName.set(sn);
           LOG.info("Registered as active master=" + this.sn);
           return true;
         }
 
+        // Invalidate the active master name so that subsequent requests do not get any stale
+        // master information. Will ne re-fetched if needed.
 
 Review comment:
   nit: will **be** re-fetched 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services