You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/12 03:40:35 UTC
svn commit: r1021578 - in
/commons/proper/pool/trunk/src/test/org/apache/commons/pool: ./ impl/
Author: sebb
Date: Tue Oct 12 01:40:34 2010
New Revision: 1021578
URL: http://svn.apache.org/viewvc?rev=1021578&view=rev
Log:
Missing @Override
Modified:
commons/proper/pool/trunk/src/test/org/apache/commons/pool/VisitTracker.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftReferenceObjectPool.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPoolFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackObjectPoolFactory.java
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/VisitTracker.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/VisitTracker.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/VisitTracker.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/VisitTracker.java Tue Oct 12 01:40:34 2010
@@ -93,6 +93,7 @@ public class VisitTracker<K> {
public K getKey() {
return key;
}
+ @Override
public String toString() {
return "Key: " + key + " id: " + id;
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java Tue Oct 12 01:40:34 2010
@@ -38,6 +38,7 @@ public class TestGenericKeyedObjectPool
super(testName);
}
+ @Override
protected KeyedObjectPool<Object,Object> makeEmptyPool(int mincapacity) {
GenericKeyedObjectPool <Object,Object>pool = new GenericKeyedObjectPool<Object,Object>(
new KeyedPoolableObjectFactory<Object,Object>() {
@@ -62,14 +63,17 @@ public class TestGenericKeyedObjectPool
return pool;
}
+ @Override
protected KeyedObjectPool<Object,Object> makeEmptyPool(KeyedPoolableObjectFactory<Object,Object> factory) {
return new GenericKeyedObjectPool<Object,Object>(factory);
}
+ @Override
protected Object getNthObject(Object key, int n) {
return String.valueOf(key) + String.valueOf(n);
}
+ @Override
protected Object makeKey(int n) {
return String.valueOf(n);
}
@@ -79,11 +83,13 @@ public class TestGenericKeyedObjectPool
private final Integer one = new Integer(1);
private final Integer two = new Integer(2);
+ @Override
public void setUp() throws Exception {
super.setUp();
pool = new GenericKeyedObjectPool<String,String>(new SimpleFactory<String>());
}
+ @Override
public void tearDown() throws Exception {
super.tearDown();
pool.clear();
@@ -1444,6 +1450,7 @@ public class TestGenericKeyedObjectPool
_thrown = null;
}
+ @Override
public void run() {
try {
preborrow = System.currentTimeMillis();
@@ -1629,10 +1636,12 @@ public class TestGenericKeyedObjectPool
}
}
+ @Override
protected boolean isLifo() {
return true;
}
+ @Override
protected boolean isFifo() {
return false;
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java Tue Oct 12 01:40:34 2010
@@ -32,6 +32,7 @@ public class TestGenericKeyedObjectPoolF
super(name);
}
+ @Override
protected KeyedObjectPoolFactory<Object,Object> makeFactory(final KeyedPoolableObjectFactory<Object,Object> objectFactory) {
return new GenericKeyedObjectPoolFactory<Object,Object>(objectFactory);
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java Tue Oct 12 01:40:34 2010
@@ -35,6 +35,7 @@ public class TestGenericObjectPoolFactor
super(name);
}
+ @Override
protected ObjectPoolFactory<Object> makeFactory(final PoolableObjectFactory<Object> objectFactory) throws UnsupportedOperationException {
return new GenericObjectPoolFactory<Object>(objectFactory);
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java Tue Oct 12 01:40:34 2010
@@ -38,6 +38,7 @@ public class TestSoftRefOutOfMemory exte
super(testName);
}
+ @Override
public void tearDown() throws Exception {
if (pool != null) {
pool.close();
@@ -148,6 +149,7 @@ public class TestSoftRefOutOfMemory exte
*/
public void testOutOfMemoryError() throws Exception {
pool = new SoftReferenceObjectPool<String>(new BasePoolableObjectFactory<String>() {
+ @Override
public String makeObject() throws Exception {
throw new OutOfMemoryError();
}
@@ -163,10 +165,12 @@ public class TestSoftRefOutOfMemory exte
pool.close();
pool = new SoftReferenceObjectPool<String>(new BasePoolableObjectFactory<String>() {
+ @Override
public String makeObject() throws Exception {
return new String();
}
+ @Override
public boolean validateObject(String obj) {
throw new OutOfMemoryError();
}
@@ -182,14 +186,17 @@ public class TestSoftRefOutOfMemory exte
pool.close();
pool = new SoftReferenceObjectPool<String>(new BasePoolableObjectFactory<String>() {
+ @Override
public String makeObject() throws Exception {
return new String();
}
+ @Override
public boolean validateObject(String obj) {
throw new IllegalAccessError();
}
+ @Override
public void destroyObject(String obj) throws Exception {
throw new OutOfMemoryError();
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftReferenceObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftReferenceObjectPool.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftReferenceObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftReferenceObjectPool.java Tue Oct 12 01:40:34 2010
@@ -31,6 +31,7 @@ public class TestSoftReferenceObjectPool
super(testName);
}
+ @Override
protected ObjectPool<Object> makeEmptyPool(int cap) {
return new SoftReferenceObjectPool<Object>(
new PoolableObjectFactory<Object>() {
@@ -44,18 +45,22 @@ public class TestSoftReferenceObjectPool
);
}
+ @Override
protected ObjectPool<Object> makeEmptyPool(final PoolableObjectFactory<Object> factory) {
return new SoftReferenceObjectPool<Object>(factory);
}
+ @Override
protected Object getNthObject(int n) {
return String.valueOf(n);
}
+ @Override
protected boolean isLifo() {
return false;
}
+ @Override
protected boolean isFifo() {
return false;
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPoolFactory.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPoolFactory.java Tue Oct 12 01:40:34 2010
@@ -32,6 +32,7 @@ public class TestStackKeyedObjectPoolFac
super(name);
}
+ @Override
protected KeyedObjectPoolFactory<Object,Object> makeFactory(final KeyedPoolableObjectFactory<Object,Object> objectFactory) throws UnsupportedOperationException {
return new StackKeyedObjectPoolFactory<Object,Object>(objectFactory);
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackObjectPoolFactory.java?rev=1021578&r1=1021577&r2=1021578&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackObjectPoolFactory.java Tue Oct 12 01:40:34 2010
@@ -33,6 +33,7 @@ public class TestStackObjectPoolFactory
super(name);
}
+ @Override
protected ObjectPoolFactory<Object> makeFactory(final PoolableObjectFactory<Object> objectFactory) throws UnsupportedOperationException {
return new StackObjectPoolFactory<Object>(objectFactory);
}