You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/05/02 12:52:16 UTC

[GitHub] spark pull request: [WIP] SPARK-1698: Improve spark integration

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/598#issuecomment-42016578
  
    Can you explain why this resolves any of the issues you identified? See my comment son SPARK-1698. shade is generally better than assembly for making uber jars, not least of which for its file-collision-handling mechanisms, which you remove here. Are you trying to create an artifact that has jars within jars instead? This could be useful, but has its own issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---