You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2025/08/03 18:58:10 UTC
[PR] fix(explore): Fix missing await for async buildV1ChartDataPayload calls [superset]
mistercrunch opened a new pull request, #34528:
URL: https://github.com/apache/superset/pull/34528
PR #34383 made buildV1ChartDataPayload async to support complex chart logic, but missed updating two critical call sites to await the Promise:
1. In saveModalActions.ts - getSlicePayload was calling buildV1ChartDataPayload without await, causing query_context to be saved as "{}" (stringified Promise)
2. In ExploreChartPanel/index.jsx - updateQueryContext was also missing await
This caused all charts created after PR #34383 to have invalid query_context, leading to "Error loading chart datasources" warnings in dashboards.
Fixes:
- Made getSlicePayload async and added await for buildV1ChartDataPayload
- Updated all callers of getSlicePayload to await it
- Added await in ExploreChartPanel's updateQueryContext
- Updated all related tests to handle async behavior
This ensures charts are saved with proper query_context instead of a stringified Promise.
Fixes regression from #34383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): Fix missing await for async buildV1ChartDataPayload calls [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #34528:
URL: https://github.com/apache/superset/pull/34528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org