You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 07:28:55 UTC
[GitHub] [arrow] thatstatsguy opened a new pull request, #14655: Update FlightSql.rst
thatstatsguy opened a new pull request, #14655:
URL: https://github.com/apache/arrow/pull/14655
Add Go example to documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #14655: [MINOR] Add Flight SQL Example Link
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14655:
URL: https://github.com/apache/arrow/pull/14655#issuecomment-1323752835
The [Cookbook](https://arrow.apache.org/cookbook/) is what we use for examples. That said Flight SQL examples would probably be too long to fit that well.
I also don't think the examples in the source tree are really meant as examples - at least the C++/Java ones are really harnesses for unit testing.
That said, the example is already in the [Go docs](https://pkg.go.dev/github.com/apache/arrow/go/v10@v10.0.0/arrow/flight/flightsql/example). I would be ok with adding C++/Go/Java links to 'external resources' with a disclaimer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #14655: [MINOR] Add Flight SQL Example Link
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #14655:
URL: https://github.com/apache/arrow/pull/14655#issuecomment-1490645056
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14655: Update FlightSql.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14655:
URL: https://github.com/apache/arrow/pull/14655#issuecomment-1316505489
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- closed pull request #14655: [MINOR] Add Flight SQL Example Link
Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- closed pull request #14655: [MINOR] Add Flight SQL Example Link
URL: https://github.com/apache/arrow/pull/14655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #14655: [MINOR] Add Flight SQL Example Link
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14655:
URL: https://github.com/apache/arrow/pull/14655#issuecomment-1317244838
Thanks!
This is meant as a specification document. Perhaps the right place to put this is in the Go docs themselves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thatstatsguy commented on pull request #14655: [MINOR] Add Flight SQL Example Link
Posted by GitBox <gi...@apache.org>.
thatstatsguy commented on PR #14655:
URL: https://github.com/apache/arrow/pull/14655#issuecomment-1322610492
Thanks for the feedback David!
I guess the underlying issue here is I really struggled to find an example for implementing Apache Arrow SQL.
I think others may have struggled too and would appreciate a central view of examples available (even if it's still experimental)
No objection to moving it elsewhere given it's a spec doc - just wanted to flag the issue I had :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org