You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/04 01:03:21 UTC
[GitHub] [beam] ihji commented on a change in pull request #15454: [BEAM-12838] Update artifact local path for DataflowRunner Java
ihji commented on a change in pull request #15454:
URL: https://github.com/apache/beam/pull/15454#discussion_r702212390
##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder = pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
Review comment:
Had offline discussion so resolve the comment.
##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder = pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
ImmutableList.Builder<StagedFile> filesToStageBuilder = ImmutableList.builder();
for (Map.Entry<String, RunnerApi.Environment> entry :
pipeline.getComponents().getEnvironmentsMap().entrySet()) {
+ RunnerApi.Environment.Builder environmentBuilder = entry.getValue().toBuilder();
+ environmentBuilder.clearDependencies();
Review comment:
Had offline discussion so resolve the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org