You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/19 11:20:59 UTC
[GitHub] [maven-fluido-skin] olamy opened a new pull request, #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
olamy opened a new pull request, #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22
Signed-off-by: Olivier Lamy <ol...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854027983
##########
src/site/apt/ITs.apt:
##########
@@ -32,6 +32,8 @@ Maven Fuido Skin ITs
* {{{./mskins-14/index.html}Search}}
+ * {{{./mskins-177-apache-analytics/index.html}Apache Analytics}}
+
Review Comment:
because all ITs are not linked and most complete one is more interesting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1103797412
> This should only be Matomo-specific, not ASF specific. Just make the full host a mandatory config option (next to site id) to make this feature usable outside ASF projects.
isn't good enough? https://github.com/apache/maven-fluido-skin/pull/22/files#diff-85dce09d83956e168d3fdfc3bfe3119e82cb7d0e18083a0a475441337168fcee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102767815
This should only be Matomo-specific, not ASF specific. Just make the full host a mandatory config option (next to site id) to make this feature usable outside ASF projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r852988270
##########
pom.xml:
##########
@@ -38,8 +38,8 @@ under the License.
<inceptionYear>2011</inceptionYear>
<scm>
- <connection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</connection>
- <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</developerConnection>
+ <connection>scm:git:https://github.com/apache/maven-fluido-skin.git</connection>
+ <developerConnection>scm:git:https://github.com/apache/maven-fluido-skin.git</developerConnection>
Review Comment:
Please drop these, the canonical repos ar at ASF, not GH
##########
src/it/mskins-177-apache-analytics/pom.xml:
##########
@@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.maven.skins</groupId>
+ <artifactId>maven-skins</artifactId>
+ <version>@project.parent.version@</version>
+ </parent>
+
+ <groupId>org.apache.maven.skins.its</groupId>
+ <artifactId>mskins-177_apache_analytics</artifactId>
+ <version>1.0-SNAPSHOT</version>
+
+ <properties>
+ <skinName>@project.name@</skinName>
+ <skinDescription>@project.description@</skinDescription>
+ <skinGroupId>@project.groupId@</skinGroupId>
+ <skinArtifactId>@project.artifactId@</skinArtifactId>
+ <skinVersion>@project.version@</skinVersion>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>@sitePluginVersion@</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven.doxia</groupId>
+ <artifactId>doxia-decoration-model</artifactId>
+ <version>@doxiaSitetoolsVersion@</version>
+ </dependency>
+ </dependencies>
+ </plugin>
+ </plugins>
+ </build>
+
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-project-info-reports-plugin</artifactId>
+ <version>3.0.0</version>
Review Comment:
Use 3.2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853468880
##########
pom.xml:
##########
@@ -38,8 +38,8 @@ under the License.
<inceptionYear>2011</inceptionYear>
<scm>
- <connection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</connection>
- <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</developerConnection>
+ <connection>scm:git:https://github.com/apache/maven-fluido-skin.git</connection>
+ <developerConnection>scm:git:https://github.com/apache/maven-fluido-skin.git</developerConnection>
Review Comment:
not sure what is canonical when using git....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102523686
depends on https://github.com/apache/maven-doxia-sitetools/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854029481
##########
pom.xml:
##########
@@ -260,6 +261,7 @@ under the License.
<goals>
<goal>site</goal>
</goals>
+ <streamLogsOnFailures>true</streamLogsOnFailures>
Review Comment:
yes because it helps me when writing/debugging IT test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy merged pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro
Posted by GitBox <gi...@apache.org>.
olamy merged PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1103131600
makes sense using something generic such `custom/matomo/..` I will change that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102773768
> This should only be Matomo-specific, not ASF specific. Just make the full host a mandatory config option (next to site id) to make this feature usable outside ASF projects.
I like that. It could be in `custom/matomo/...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1103524637
This deserves some documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853973657
##########
pom.xml:
##########
@@ -260,6 +261,7 @@ under the License.
<goals>
<goal>site</goal>
</goals>
+ <streamLogsOnFailures>true</streamLogsOnFailures>
Review Comment:
because when running IT locally it's more convenient to have the output of failed test in the console rather than looking into a build.log file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1104569223
> The CDATA block is broken:  
>
> Please remove it, it has no use these days.
[interesting ](https://github.com/apache/maven-parent/blob/d12d10719083fb4963204e6e2b49d99684df3c0b/src/site/site.xml#L67)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support Matomo (e.g. Apache Analytics) as macro
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1104578871
> Please remove it, it has no use these days.
`CDATA` you mean? because I don't understand the link with the screenshot attached
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853812905
##########
pom.xml:
##########
@@ -101,6 +101,7 @@ under the License.
<bootstrap.version>2.3.2</bootstrap.version>
<jquery.version>1.11.2</jquery.version>
<sitePluginVersion>3.8.2</sitePluginVersion>
+ <doxiaSitetoolsVersion>1.11.2-SNAPSHOT</doxiaSitetoolsVersion>
Review Comment:
Not required anymore.
##########
pom.xml:
##########
@@ -260,6 +261,7 @@ under the License.
<goals>
<goal>site</goal>
</goals>
+ <streamLogsOnFailures>true</streamLogsOnFailures>
Review Comment:
What does this change in this case?
##########
pom.xml:
##########
@@ -38,8 +38,8 @@ under the License.
<inceptionYear>2011</inceptionYear>
<scm>
- <connection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</connection>
- <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git</developerConnection>
+ <connection>scm:git:https://github.com/apache/maven-fluido-skin.git</connection>
+ <developerConnection>scm:git:https://github.com/apache/maven-fluido-skin.git</developerConnection>
Review Comment:
The repos on ASF infra. Please drop this, it is unrelated to the issue.
##########
src/site/apt/index.apt.vm:
##########
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
</project>
+-----+
+** Matomo (i.e ApacheAnalytics)
Review Comment:
e.g.,
##########
src/site/apt/index.apt.vm:
##########
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
</project>
+-----+
+** Matomo (i.e ApacheAnalytics)
+
+ Users can optionally enable <<Matomo>>.
+ How to configure it for Apache Analytics:
Review Comment:
This sample doesn't actually show how to configure for Apache Analytics, values aren't filled.
##########
src/it/mskins-177-apache-analytics/src/site/site.xml:
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ -->
+
+<project xmlns="http://maven.apache.org/DECORATION/1.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/DECORATION/1.1.0 http://maven.apache.org/xsd/decoration-1.1.0.xsd"
+ name="${skinName}">
+
+ <skin>
+ <groupId>${skinGroupId}</groupId>
+ <artifactId>${skinArtifactId}</artifactId>
+ <version>${skinVersion}</version>
+ </skin>
+
+ <!-- START SNIPPET: skin-apache-analytics -->
+ <custom>
+ <matomo>
+ <siteId>3</siteId>
+ <url>analytics.apache.org</url>
Review Comment:
Thats not a url, but rather a hostname. You should provide a full URL for maximun flexiblity.
##########
src/main/resources/META-INF/maven/site.vm:
##########
@@ -52,6 +52,11 @@
#**##end
#**##if( $headContent )$headContent#end
#**##googleAnalytics( $decoration.googleAnalyticsAccountId )
+#**##if ( $decoration.getCustomValue( 'matomo.url' ) && $decoration.getCustomValue( 'matomo.url' ) != ''
+ && $decoration.getCustomValue( 'matomo.siteId' ) && $decoration.getCustomValue( 'matomo.siteId' ) != ''
+ )
+#* *##matomo( $decoration.custom.getChild('matomo') )
Review Comment:
This test should be pushed into the macro, just like here:
https://github.com/apache/maven-fluido-skin/blob/0cef65c2abd91af3297b2e7ec95790e7b4bfabb0/src/main/resources/META-INF/maven/site-macros.vm#L548-L570
##########
src/it/mskins-177-apache-analytics/src/site/site.xml:
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ -->
+
+<project xmlns="http://maven.apache.org/DECORATION/1.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/DECORATION/1.1.0 http://maven.apache.org/xsd/decoration-1.1.0.xsd"
+ name="${skinName}">
+
+ <skin>
+ <groupId>${skinGroupId}</groupId>
+ <artifactId>${skinArtifactId}</artifactId>
+ <version>${skinVersion}</version>
+ </skin>
+
+ <!-- START SNIPPET: skin-apache-analytics -->
+ <custom>
+ <matomo>
+ <siteId>3</siteId>
+ <url>analytics.apache.org</url>
+ <options>
+ <disableCookies/>
+ <trackPageView/>
+ <enableLinkTracking/>
+ <foo>Bar</foo>
+ </options>
+ </matomo>
Review Comment:
I like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854013055
##########
src/site/apt/index.apt.vm:
##########
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
</project>
+-----+
+** Matomo (e.g ApacheAnalytics)
Review Comment:
Space missing
##########
src/site/apt/ITs.apt:
##########
@@ -32,6 +32,8 @@ Maven Fuido Skin ITs
* {{{./mskins-14/index.html}Search}}
+ * {{{./mskins-177-apache-analytics/index.html}Apache Analytics}}
+
Review Comment:
Why isn't the second IT no linked?
##########
pom.xml:
##########
@@ -260,6 +261,7 @@ under the License.
<goals>
<goal>site</goal>
</goals>
+ <streamLogsOnFailures>true</streamLogsOnFailures>
Review Comment:
That's unrelated to this PR.
##########
src/site/apt/index.apt.vm:
##########
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
</project>
+-----+
+** Matomo (e.g ApacheAnalytics)
+
+ Users can optionally enable <<Matomo>>.
+ How to configure it for Apache Analytics, the <<options>> element will contain some configuration (here some privacy setup) :
Review Comment:
No French space before colon
##########
src/site/apt/index.apt.vm:
##########
@@ -166,6 +166,29 @@ Welcome to ${project.name}!
</project>
+-----+
+** Matomo (e.g ApacheAnalytics)
Review Comment:
e.g.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org