[jira] [Commented] (KAFKA-6371) FetchMetadata creates unneeded Strings on instantiation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292242#comment-16292242 ] 

ASF GitHub Bot commented on KAFKA-6371:
---------------------------------------

GitHub user mayt opened a pull request:

    https://github.com/apache/kafka/pull/4328

    KAFKA-6371 Fix DelayedFetch toString

    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayt/kafka KAFKA-6371

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4328
    
----

----


> FetchMetadata creates unneeded Strings on instantiation
> -------------------------------------------------------
>
>                 Key: KAFKA-6371
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6371
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.0.1, 0.10.1.1, 0.10.2.1
>            Reporter: Maytee Chinavanichkit
>            Assignee: Maytee Chinavanichkit
>            Priority: Minor
>             Fix For: 0.10.0.2, 0.10.1.2, 0.10.2.2
>
>
> My colleague and I were taking a heap dump to investigate the memory usage of a broker. From the dump, we saw a number of object strings with the message {{onlyCommitted: <redacted>}} and {{partitionStatus: <redacted>]}}. Upon investigation, these objects were being instantiated when the {{FetchMetadata}} object is constructed. The toString method here is malformed and the last two lines are executed as a block instead of being concatenated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)