[jira] [Commented] (AVRO-1203) Support for obtaining the number of bytes written

["Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727985#comment-16727985 ] 

Thiruvalluvan M. G. commented on AVRO-1203:
-------------------------------------------

This exposes too much of implementation. This will make it hard to modify the implementation in the future. As [~pjacobs] suggests, it should be possible to flush and check the bytes written (`OutputStream::byteCount()` exists exactly for that purpose).

> Support for obtaining the number of bytes written
> -------------------------------------------------
>
>                 Key: AVRO-1203
>                 URL: https://issues.apache.org/jira/browse/AVRO-1203
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: c++
>    Affects Versions: 1.7.2
>            Reporter: Manuel Simoni
>            Priority: Major
>             Fix For: 1.9.0
>
>
> I've used the Avro C++ library to implement Avro support for Node.js [1].
> In the course of this, I needed to extend the library so that it keeps
> track of the number of bytes written to a stream by an encoder.
> These changes mostly required making various headers public, and only
> small changes to implementation code.
> Here's a detailed list of changes:
> - Make the following headers public:
>   -- BinaryEncoder.hh
>   -- Symbol.hh
>   -- ValidatingCodec.hh
>   -- json/JsonDom.hh
>   -- json/JsonEncoder.hh
>   -- json/JsonIO.hh
> - Extend StreamWriter to keep track of number of bytes written (bytesWritten_, getBytesWritten())
> - Expose BinaryEncoder's and JsonEncoder's StreamWriter via getStreamWriter() method
> The complete changes can be viewed here on Github:
> https://github.com/manuel/avro-cpp/commit/f77c108a04fc9e39397eb2fae86b2710b64e2c8a
> The code is available in the "manuel/avro-cpp" Github Repo on the
> "upstream_submit" branch:
> https://github.com/manuel/avro-cpp/tree/upstream_submit
> We would love to have this functionality added to the Avro C++ library.
> [1] https://github.com/collectivemedia/node-avro



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)