You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/05/13 00:17:26 UTC

[kudu-CR] Add an all-virtual ServerPicker class and a meta cache backed implementation

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3017

to look at the new patch set (#6).

Change subject: Add an all-virtual ServerPicker class and a meta cache backed implementation
......................................................................

Add an all-virtual ServerPicker class and a meta cache backed implementation

This pulls out the replica picking code from WriteRpc and into an implementation
of the new ServerPicker, all-virtual class.

The new server picker implementation, which is backed by the meta cache, fully
readies the replica before handing it over to WriteRpc. This makes the writing
logic simpler (less callbacks) and makes the replica picking code possibly reusable.

Again, this is just a refactor of existing code so no new tests were added.

Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5
---
M src/kudu/client/batcher.cc
M src/kudu/rpc/rpc.h
2 files changed, 272 insertions(+), 149 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/3017/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>