[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3869: [K8S][IT][BUG] Fix the issue that connect conf is not used in the jdbc connection string

[GitBox <gi...@apache.org>]

zwangsheng commented on code in PR #3869:
URL: https://github.com/apache/incubator-kyuubi/pull/3869#discussion_r1039419500


##########
integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/deployment/KyuubiOnKubernetesTestsSuite.scala:
##########
@@ -72,10 +74,17 @@ class KyuubiOnKubernetesWithSparkTestsBase extends WithKyuubiServerOnKubernetes
  *  ------------       -------------------------------------------------      ---------------------
  */
 class KyuubiOnKubernetesWithClientSparkTestsSuite
-  extends KyuubiOnKubernetesWithSparkTestsBase {
+  extends KyuubiOnKubernetesWithSparkTestsBase with SparkQueryTests {
   override protected def connectionConf: Map[String, String] = {
-    super.connectionConf ++ Map("spark.submit.deployMode" -> "client")
+    super.connectionConf ++ Map(
+      "spark.submit.deployMode" -> "client",
+      "spark.driver.host" -> kyuubiServerIp,
+      "kyuubi.frontend.connection.url.use.hostname" -> "false")
   }
+
+  override protected def jdbcUrl: String = getJdbcUrl(connectionConf)
+
+  override protected lazy val user: String = "client"

Review Comment:
   In this test, Kyuubi use `USER` share level create spark engine. If use same user, kyuubi won't create spark engine in client deploy mode instead of using local mode.
   
   If we use `CONNECTION` share level, will create one spark engine for each sql, which we can't afford. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org